-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis of failing character tests (after #85) #90
Comments
Also for people debugging these, https://util.unicode.org/UnicodeJsps/bidic.jsp?s=%D7%90%281%29&b=0&u=140&d=2 is amazing |
After #92, so far we have these failures: Explicit directional overrides applied to paired brackets 8 tests
Combinations of paired brackets, numbers, and directional formatting characters 11 tests
|
Unfortunately #92 causes a massive pile of failures in the basic tests. |
Down to two failures in #92! And fixed the basic test failures it was causing. There are still ~100 failing basic tests though. |
Ah, the problem is that isolating run sequences can have gaps in them. I'm going to need to rearchitect some of the N0 work .... |
The last two failures are https://github.com/unicode-org/properties/issues/70, and it's a whopper. |
Ah, it's actually not that much of a whopper since it only affects things that I've done on this repo recently 😁, the existing code actually handled this pretty well. The basic issue is that the weak and neutral rules must apply within an isolating run sequence only, even if it has gaps. This is mostly fine for all of our iterations, except for a couple cases of lookahead that I did incorrectly, and every case of lookbehind. This is fixable. |
.... and the character tests pass! still got a ways to go on the basic tests |
This is where I'm tracking all of the failures left in the character tests after #85 and #91. This is not checking the 314 failures (250 after #87) for the basic tests.
I'm categorizing them by their section in BidiConformanceTest.txt, and filling in issue numbers as necessary. Investigations on the ??s would be appreciated!
Explicit directional overrides applied to paired brackets (#89)
8 tests
Nonspacing marks applied to paired brackets. These cases exercise the ignoring of bc=BN characters (#89, probably)
4 tests
Sequences containing directional formatting characters (#89)
6 tests
Combinations of paired brackets, numbers, and directional formatting characters (probably involves some of #89)
11 tests
The text was updated successfully, but these errors were encountered: