fix: Replaced object-hash with hash-sum to hopefully get a more deter…

…ministic hash

package.json

@@ -28,20 +28,20 @@
     },
     "dependencies": {
         "cuid": "^2.1.6",
-        "object-hash": "^1.3.1",
+        "hash-sum": "^1.0.2",
         "promise-completion-source": "^1.0.0"
     },
     "peerDependencies": {
         "react": "^16.6.0",
-        "typescript-log": "^1.1.0",
-        "tslib": "^1.9.3"
+        "tslib": "^1.9.3",
+        "typescript-log": "^1.1.0"
     },
     "devDependencies": {
         "@types/cuid": "^1.3.0",
         "@types/enzyme": "^3.9.0",
         "@types/enzyme-adapter-react-16": "^1.0.5",
+        "@types/hash-sum": "^1.0.0",
         "@types/jest": "^24.0.12",
-        "@types/object-hash": "^1.2.0",
         "@types/react": "^16.8.6",
         "@types/react-dom": "^16.8.2",
         "enzyme": "^3.8.0",
@@ -58,6 +58,7 @@
         "tslint-eslint-rules": "^5.4.0",
         "tslint-react": "^4.0.0",
         "typescript": "^3.3.3333",
-        "typescript-log": "^1.1.0"
+        "typescript-log": "^1.1.0",
+        "tslib": "^1.9.3"
     }
 }

readme.md

@@ -189,7 +189,11 @@ When you register `resources` they return a DataLoader, a fully type-safe React
 
 You can load multiple DataLoaders in a single page. Each `DataLoader` will fetch the resource once, sharing the data between data-loaders when the parameters match.
 
-​​The `DataProvider` component  is responsible for fetching the data. When `DataLoader`s are mounted they register with the data provider so it can notify the `DataLoader`s when any relevant data is updated. This means DataLoaders only re-render when the data they are interested in is updated.
+​​The `DataProvider` component is responsible for fetching the data. When `DataLoader`s are mounted they register with the data provider so it can notify the `DataLoader`s when any relevant data is updated. This means DataLoaders only re-render when the data they are interested in is updated.
+
+### Params hashing
+
+Behind the scenes the data loader uses a library called `hash-sum` to create hashes of the parameter object. You can override it on the DataProvider
 
 ## More info
 

src/data-loader-store-and-loader.ts

@@ -1,4 +1,3 @@
-import objectHash from 'object-hash'
 import { DataProviderEvents } from './events'
 import { LoaderState, LoaderStatus } from './data-loader-state'
 import { isPromise } from './utils'
@@ -22,6 +21,9 @@ export interface LoadParams {
     [param: string]: any
 }
 
+/** Takes an object and produces a consistent hash */
+export type ObjectHash = (obj: object) => string
+
 // Some other names
 // DataLoaderDataAccessor
 // DataLoaderCore
@@ -54,6 +56,7 @@ export class DataLoaderStoreAndLoader {
         onEvent: (event: DataProviderEvents) => void | Promise<any>,
         initialState: DataLoaderState | undefined,
         private performLoad: (dataLoadParams: LoadParams) => Promise<any> | any,
+        private objectHash: ObjectHash,
         public isServerSideRender: boolean,
     ) {
         this.onEvent = event => {
@@ -84,7 +87,7 @@ export class DataLoaderStoreAndLoader {
               }, {})
             : dataLoadParams
 
-        return objectHash(cacheParams)
+        return this.objectHash(cacheParams)
     }
 
     attach(

src/data-provider.tsx

@@ -2,14 +2,20 @@ import React from 'react'
 import { DataLoaderResources } from './data-loader-resources'
 import { DataProviderEvents } from './events'
 import { DataLoaderContextComponent } from './data-loader-context'
-import { DataLoaderStoreAndLoader, DataLoaderState } from './data-loader-store-and-loader'
+import {
+    DataLoaderStoreAndLoader,
+    DataLoaderState,
+    ObjectHash,
+} from './data-loader-store-and-loader'
 
 export interface Props {
     initialState?: DataLoaderState
     onEvent?: (event: DataProviderEvents) => void | Promise<any>
     isServerSideRender?: boolean
     resources: DataLoaderResources<any>
     globalProps?: object
+    /** Override the object hasing function */
+    objectHash?: ObjectHash
 }
 
 export class DataLoaderProvider extends React.Component<Props> {
@@ -30,10 +36,11 @@ export class DataLoaderProvider extends React.Component<Props> {
 
                 return dataLoader({
                     ...this.props.globalProps,
-                    ...params
+                    ...params,
                 })
             },
-            this.props.isServerSideRender || false
+            this.props.objectHash || require('hash-sum'),
+            this.props.isServerSideRender || false,
         )
     }