Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for feature: support geometric types with rust-geo #244

Closed
kestred opened this issue Mar 9, 2017 · 4 comments
Closed

Request for feature: support geometric types with rust-geo #244

kestred opened this issue Mar 9, 2017 · 4 comments

Comments

@kestred
Copy link
Contributor

kestred commented Mar 9, 2017

Would it make sense to support postgreSQL's builtin geometric types using the https://github.com/georust/rust-geo crate?

It is the most used (and i.m.o. seems the most well designed) crate that exists for geo/gis in rust.

Type Correspondence

Rust Type Postgres Type
geo::Coordinate, geo::Point POINT
(possibly geo::LineString or geo::MultiPoint) LINE, LSEG
geo::Bbox BOX
geo::LineString PATH
geo::Polygon POLYGON
@sfackler
Copy link
Owner

Sure, sounds reasonable to me! I'd be happy to take PR adding the conversions, or I can take a crack at it when I have a chance.

@kestred
Copy link
Contributor Author

kestred commented Mar 10, 2017

Great. I'll implement it and create a PR.

@pka
Copy link

pka commented Apr 2, 2017

This could lead to some confusion. People working with geometries within PostgreSQL are using PostGIS. https://github.com/andelf/rust-postgis isn't using rust-geo geometries, because it leads to overhead for converting between different geometry implementations. There was a long discussion about that, which ended in the consensus that rust-geo needs a trait based implementation.

@rofrol
Copy link

rofrol commented Apr 14, 2017

Close issue?

@sfackler sfackler closed this as completed Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants