From 73760610e959ae868de23de3da661d237fbcb106 Mon Sep 17 00:00:00 2001 From: Erik Michaels-Ober Date: Thu, 13 Jun 2013 06:49:58 -0700 Subject: [PATCH] Ignore case of profile image extension Closes #414. --- lib/twitter/user.rb | 2 +- spec/twitter/user_spec.rb | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/lib/twitter/user.rb b/lib/twitter/user.rb index 30e51ed4b..93e230454 100644 --- a/lib/twitter/user.rb +++ b/lib/twitter/user.rb @@ -4,7 +4,7 @@ module Twitter class User < Twitter::BasicUser - PROFILE_IMAGE_SUFFIX_REGEX = /_normal(\.gif|\.jpe?g|\.png)$/ + PROFILE_IMAGE_SUFFIX_REGEX = /_normal(\.gif|\.jpe?g|\.png)$/i include Twitter::Creatable include Twitter::Exceptable attr_reader :connections, :contributors_enabled, :default_profile, diff --git a/spec/twitter/user_spec.rb b/spec/twitter/user_spec.rb index ac5177cee..c19ca4982 100644 --- a/spec/twitter/user_spec.rb +++ b/spec/twitter/user_spec.rb @@ -185,6 +185,14 @@ expect(user.profile_image_url(:mini)).to eq "http://a0.twimg.com/profile_images/1759857427/image1326743606_mini.png" end end + context "with capitalized file extension" do + it "returns the correct image" do + user = Twitter::User.new(:id => 7505382, :profile_image_url_https => "https://si0.twimg.com/profile_images/67759670/DSCN2136_normal.JPG") + expect(user.profile_image_url(:original)).to eq "http://si0.twimg.com/profile_images/67759670/DSCN2136.JPG" + expect(user.profile_image_url(:bigger)).to eq "http://si0.twimg.com/profile_images/67759670/DSCN2136_bigger.JPG" + expect(user.profile_image_url(:mini)).to eq "http://si0.twimg.com/profile_images/67759670/DSCN2136_mini.JPG" + end + end end describe "#profile_image_url_https" do @@ -218,6 +226,14 @@ expect(user.profile_image_url_https(:mini)).to eq "https://a0.twimg.com/profile_images/1759857427/image1326743606_mini.png" end end + context "with capitalized file extension" do + it "returns the correct image" do + user = Twitter::User.new(:id => 7505382, :profile_image_url_https => "https://si0.twimg.com/profile_images/67759670/DSCN2136_normal.JPG") + expect(user.profile_image_url_https(:original)).to eq "https://si0.twimg.com/profile_images/67759670/DSCN2136.JPG" + expect(user.profile_image_url_https(:bigger)).to eq "https://si0.twimg.com/profile_images/67759670/DSCN2136_bigger.JPG" + expect(user.profile_image_url_https(:mini)).to eq "https://si0.twimg.com/profile_images/67759670/DSCN2136_mini.JPG" + end + end end describe "#profile_image_url?" do