Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Throttle Fault Timers #37

Closed
rafguevara14 opened this issue Feb 2, 2023 · 3 comments · Fixed by #39
Closed

Fix Throttle Fault Timers #37

rafguevara14 opened this issue Feb 2, 2023 · 3 comments · Fixed by #39
Assignees
@rafguevara14
Labels
High priority

Comments

@rafguevara14
Copy link
Collaborator

We need to figure out when these are triggered so that we can avoid them when developing and testing other features. It's also possible that these don't really work as expected...

vcu-fw/VCU/Phantom/tasks/source/task_throttle_actor.c

Line 110 in a6cba00

// TODO: Add range fault checks

@rafguevara14 rafguevara14 mentioned this issue Feb 2, 2023
Merged
1 task
@kkramer215
Copy link
Contributor

Best to figure this out ASAP to avoid trying to "fix" other code that might be impacted by the timers. Would be good to try to isolate the timers to see if working properly or not.

@rafguevara14
Copy link
Collaborator Author

rafguevara14 commented Feb 17, 2023 •
edited
Loading

Looks like this gets fixed by the new architectural design. will link PR once it's up!
Specifically, watch out for the NotifyStateMachineFromTimer in these changes

https://github.com/sfuphantom/vcu-fw/blob/Finalize-VCU-Infrastructure/Diagrams/Threads/threads.svg

@rafguevara14 rafguevara14 self-assigned this Mar 3, 2023
@rafguevara14 rafguevara14 linked a pull request Mar 3, 2023 that will close this issue
Finalize VCU Infrastructure #39
Merged
@rafguevara14
Copy link
Collaborator Author

PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafguevara14 rafguevara14

Labels
High priority
Projects
VCU FW - Controls
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finalize VCU Infrastructure sfuphantom/vcu-fw
2 participants
@kkramer215 @rafguevara14