Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use __all__ to explictly control the APIs. #386

Closed
hnyls2002 opened this issue Apr 23, 2024 · 0 comments · Fixed by #416
Closed

Use __all__ to explictly control the APIs. #386

hnyls2002 opened this issue Apr 23, 2024 · 0 comments · Fixed by #416
Assignees
@hnyls2002

Comments

@hnyls2002
Copy link
Collaborator

Current __init__.py uses from xxx import *, which is not a good way to expose APIs.

sglang/python/sglang/__init__.py

Lines 1 to 4 in 150d702

__version__ = "0.1.14"
from sglang.api import *
from sglang.global_config import global_config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hnyls2002 hnyls2002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make public APIs more standard. sgl-project/sglang
1 participant
@hnyls2002