-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1 loss or SmoothL1Loss? #60
Comments
@jonathan016 did you try it yet ? I'll try and post result here once I have some results. |
Hi @adityag6994 , I didn't try it due to my research's limited resources and time. However, using |
Okay, I started the experiment will have something by tomorrow. Same, L1Loss worked for me on the dateset I tried it on. Side question, I just noticed there is no Softmax being used when calculating cross Entropy https://github.com/sgrvinod/a-PyTorch-Tutorial-to-Object-Detection/blob/master/model.py#L629, do you have any idea, or am I missing something here ? Thanks, |
@jonathan016 so I changed https://github.com/sgrvinod/a-PyTorch-Tutorial-to-Object-Detection/blob/master/model.py#L549
to this
and there was less than 1% drop on |
Wow, that's interesting @adityag6994, thanks for the experiment! At least now we know which works best for your case, since different datasets may require different approach 😁 Anyway, softmax is calculated implicitly in |
That makes sense now. Thank you @jonathan016 |
With the experiment results provided by @adityag6994, I believe my questions have been answered. Closing this issue for now. Thanks a lot @adityag6994! |
Hi, I've been reading through the code and I found that L1 loss is used instead of Smooth L1 loss for localization loss. This is quite different from the paper's procedure, where as far as I know SSD uses Smooth L1 loss.
https://github.com/sgrvinod/a-PyTorch-Tutorial-to-Object-Detection/blob/master/model.py#L549
https://github.com/sgrvinod/a-PyTorch-Tutorial-to-Object-Detection/blob/master/model.py#L612
My questions are:
SmoothL1Loss
as implemented in PyTorch as of right now?Thank you in advance.
The text was updated successfully, but these errors were encountered: