fix(backend): compare like types for nextLineId #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #351
Summary
Simple fix to compare IDs correctly. Before it was comparing an array with a string.
Tests
Tested with first and second lines of various shabads. Also tested with Asa Ki Vaar. Noticed that the
<<symbol is not shown in AKV. Can't remember if that was how it was before, but regardless it still looks okay and functions the same. You always can see where the jump will take you.TTR
I won't lie, this took a lot longer than I expected. Took 60 minutes to read the code base and hone in on the area. Another 30 minutes to figure out how to debug in VS Code. And then finally another 15 to resolve and test various shabads.