feat(frontend/presenter): only advance on click if focused #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you test this on an iPad/mobile device of sorts? Single tap should
advance a line
…On Wed, Jun 3, 2020, 08:06 Harjot Singh ***@***.***> wrote:
@Harjot1Singh <https://github.com/Harjot1Singh> requested your review on:
#577 <#577>
feat(frontend/presenter): only advance on click if focused.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#577 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLZ3BZVW2NEK3BUWTUZV6DRUY4DNANCNFSM4NRTJJDQ>
.
|
It does |
bhajneet
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Only advances the presenter slide if the window is focused. Uses an approach of taking a mouse click as a focus event on anything that is not Mac, and the focus event on Mac.
See #388 for more description and considered solutions.
Tests for unexpected behavior
Time spent on PR
Linked issues
Closes #388
Reviewers
@bhajneet