feat(frontend/settings): organize overlay buttons next to each other #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideally there would be a single button component for the entire settings page since there are now multiple ways to show a button, but have used grid items for spacing
it makes sense that a user would customize something on the theme tool then look for the folder where they must put the generated file similarly it makes sense for users who do not wish to customize and simply want to drop in an organization's theme file and then select it to have the overlay folder button higher up
bhajneet
added
Effort 1
bhajneet
changed the title
Harjot1Singh
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Organizes buttons in settings/overlay a bit better
Tests for unexpected behavior
Time spent on PR
Linked issues
Fix #
Reviewers
@Harjot1Singh