fix(frontend/presenter): use source abbreviation in copy citation hotkey #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saihaj
added
Status: Merge
Impacts Few
bhajneet
added
Impacts Some
|
@bhajneet should abbreviations also be in search results? |
|
I think they already are @saihaj ? |
|
Yes abbreviations are being used in search results as of #575. Technically when I resolved that I should have checked hotkeys too but I forgot and that is why we have this 🙂 |
Harjot1Singh
approved these changes
Nov 3, 2020
Harjot1Singh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Use the source abbreviation to have BoS style when copy pasting as done for serach results in #575
Time spent on PR
15 mins - 30 seconds for fix and rest time spent to find the line because I forgot where it was : )
Linked issues
Fix #620
Reviewers
@Harjot1Singh