Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Autocomplete component. An Autocomplete is not a combobox nor a command component. #3423

Closed
2 tasks done
samuelkarani opened this issue Apr 8, 2024 · 5 comments
Closed
2 tasks done

Comments

@samuelkarani
Copy link

samuelkarani commented Apr 8, 2024

Feature description

Shadcn is lacking the Autocomplete component. This is an input text/search that shows a popover when focused or when typing otherwise no popover is shown (unlike command component). Also the trigger for the popover/dropdown is the input component only being focussed or receiving text input, and not some additional component (unlike the combobox component)

Example of a custom shadcn autocomplete component: https://www.armand-salle.fr/post/autocomplete-select-shadcn-ui
Example of an standalone autocomplete npm package: https://react-autosuggest.js.org/
Example from mantine ui: https://mantine.dev/core/autocomplete

Affected component/components

No response

Additional Context

Additional details here...

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues and PRs
@samuelkarani samuelkarani changed the title [feat]: Autocomplete component. An Autocomplete is not a combobox nor a command component. All different components. [feat]: Autocomplete component. An Autocomplete is not a combobox nor a command component. All are different components. Apr 8, 2024
@samuelkarani samuelkarani changed the title [feat]: Autocomplete component. An Autocomplete is not a combobox nor a command component. All are different components. [feat]: Autocomplete component. An Autocomplete is not a combobox nor a command component. Apr 8, 2024
@kachkaev
Copy link
Contributor

I believe this is a duplicate of #173.

@alkadoHs
Copy link

I been looking for this as well, thanks for the examples

@samuelkarani
Copy link
Author

I believe this is a duplicate of #173.

Actually it is not, but it's related.

@shadcn shadcn added the Stale label Jun 3, 2024
@shadcn
Copy link
Collaborator

shadcn commented Jun 10, 2024

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

@shadcn shadcn closed this as completed Jun 10, 2024
@ersinakinci
Copy link

Hey, @samuelkarani is right. #173 is mislabeled. There are now a few closed issues as well as comments within #173 explaining that combobox !== autocomplete, but these seem to be buried by commenters who are confusing the two.

Autocomplete should be like a freeform input textbox that allows you to enter any text you want, and it also allows you to select from a list. #173 and others are, as far as I can tell, mostly about modifying the combobox format so that the popover is triggered by a textbox. The user is still fundamentally forced to pick an option.

As has been pointed out elsewhere, this is the desired behavior: https://mantine.dev/core/autocomplete/

@shadcn can we reopen this issue? I think the desire for this component is greater than might appear at first blush, people keep asking for it but it's spread out across different issues and comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants