Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 🎨 moves notification components to separate files #60

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

shaheer-deriv
Copy link
Owner

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@coveralls
Copy link

coveralls commented Aug 10, 2023

Pull Request Test Coverage Report for Build 5853046990

  • 28 of 35 (80.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 9.796%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Containers/NotificationsDialog/notifications-dialog.jsx 0 1 0.0%
packages/core/src/App/Containers/NotificationsDialog/notifications-list.tsx 15 21 71.43%
Totals Coverage Status
Change from base Build 5795294153: 0.02%
Covered Lines: 9700
Relevant Lines: 82170

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Generating Lighthouse report...

@shaheer-deriv shaheer-deriv merged commit 09b8b6a into shaheer/WALL-1336 Aug 14, 2023
2 checks passed
shaheer-deriv pushed a commit that referenced this pull request Jan 17, 2024
…om#12610)

* chore: initial setup

* chore: initial setup

* chore: configured webpack

* fix: changed lint rules

* chore: incorporated build config

* chore: added stylelint file

* chore: updated stylelint

* refactor: incorporated review comments

* fix: reverted webpack types

* fix: build issue

* chore: added sonarlint rules

* chore: added a test component

* fix: removed test component

* chore: copied tailwind from tradershub

* fix: dependency version mismatch

* fix: added missing eslintignore file

* chore: webpack config refactor (#60)

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com>

* fix: build failure

* fix: sonarcloud errors

* fix: added tailwind styles

* chore: types naming

* feat: added a test component

* fix: tailwind-config

* refactor: build process

* refactor: build process

* fix: removed catastrophic backtracking regex

* fix: incoporated review comments

* fix: renamed version

* feat: added flag to render account-v2

* fix: failing testcase

* fix: failing testcase

* fix: imports

* chore: updated packages

* fix: added prettier config

* chore: created timeline component

* chore: added deriv lib

* fix: added mock stepper-form

* fix: added styles

* feat: created timeline component for mobile

* fix: remove unintented changes

* fix: resolved build issues

* fix: resolved build issues

* fix: resolved build issues

* fix: resolved build issues

* fix: added regex to remove lint rules for mock and classnames

* fix: incorporated review comments

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants