Skip to content

Commit

Permalink
PR(DROP): Patch The SourceHub Bug Temporarily
Browse files Browse the repository at this point in the history
Must not merge with this commit in the PR.
  • Loading branch information
shahzadlone committed Mar 5, 2024
1 parent c8f958c commit da33990
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions acp/acp_local.go
Original file line number Diff line number Diff line change
Expand Up @@ -329,16 +329,19 @@ func (l *ACPLocalEmbedded) CheckDocAccess(
&checkDoc,
)
if err != nil {
log.ErrorE(
ctx,
"failed to check/verify doc access with local acp module",
err,
logging.NewKV("PolicyID", policyID),
logging.NewKV("ActorID", actorID),
logging.NewKV("Resource", resource),
logging.NewKV("DocID", docID),
)
return false, err
//log.ErrorE(
// ctx,
// "failed to check/verify doc access with local acp module",
// err,
// logging.NewKV("PolicyID", policyID),
// logging.NewKV("ActorID", actorID),
// logging.NewKV("Resource", resource),
// logging.NewKV("DocID", docID),
//)
// return false, err
// TODO-MUST: This change must be dropped once SourceHub fixes the bug.
// For now patching it to pass the tests that use wrong ids to test those cases.
return false, nil
}

if checkDocResponse.Valid {
Expand Down

0 comments on commit da33990

Please sign in to comment.