fix(http): Fix "Failed sending data to the peer" errors #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading curl fixes errors like "Failed sending data to the peer" flooding the log. This is described upstream in curl/curl#10591 and fixed in curl 8.2.0. Here we upgrade to curl 8.9.1 (latest as of today).
cosmin
approved these changes
Oct 24, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Oct 28, 2024
🤖 I have created a release *beep* *boop* --- ## [3.3.0](v3.2.1...v3.3.0) (2024-10-25) ### Features * Add IAMF support ([#1416](#1416)) ([dc6196d](dc6196d)), closes [#1415](#1415) * EXT-X-SESSION-KEY support ([#1427](#1427)) ([d88ed27](d88ed27)), closes [#36](#36) * **http:** Add DELETE method support ([#1442](#1442)) ([ddeacb2](ddeacb2)) ### Bug Fixes * **http:** Fix "Failed sending data to the peer" errors ([#1443](#1443)) ([2c9d100](2c9d100)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading curl fixes errors like "Failed sending data to the peer" flooding the log. This is described upstream in curl/curl#10591 and fixed in curl 8.2.0. Here we upgrade to curl 8.9.1 (latest as of today).
This required updating the way we attach c-ares to libcurl and updating CURLOPT_PUT (deprecated) to CURLOPT_UPLOAD (compatible equivalent AFAICT).