-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port media/formats/webm to CMake #1147
feat: port media/formats/webm to CMake #1147
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Will review in detail after #1143 lands. Thanks! |
4079dd0
to
96a3cb4
Compare
96a3cb4
to
aded5be
Compare
bc1fa14
to
756a99d
Compare
I'm guessing this is a Windows macro gone wrong. There's a macro in file/file.cc that deals with this, but it may need to be moved to the file.h header instead. |
7dd5823
to
63ebdba
Compare
@joeyparrish CI is finally green, please take a look 🙂 |
Will do. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like maybe one mistake. The rest looks good.
Port media/formats/webm to CMake.
Depends on #1143
Related #1047