Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Mongoose embedded HTTP server #1231

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

joeyparrish
Copy link
Member

This adds Mongoose as a third-party library, and builds on top of that an embedded HTTP server for our unit tests.

We are using a fork of Mongoose pending the merging of this PR: cesanta/mongoose#2301

The embedded web server will make our HTTP-based tests independent of httpbin.org, which will make them quick and reliable.

This adds Mongoose as a third-party library, and builds on top of that
an embedded HTTP server for our unit tests.

We are using a fork of Mongoose pending the merging of this PR:
cesanta/mongoose#2301

The embedded web server will make our HTTP-based tests independent of
httpbin.org, which will make them quick and reliable.
@joeyparrish joeyparrish requested a review from kqyang July 13, 2023 22:57
Copy link
Contributor

@kqyang kqyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

Good call to switch to use a local web server framework

packager/media/test/test_web_server.cc Outdated Show resolved Hide resolved
packager/media/test/test_web_server.cc Outdated Show resolved Hide resolved
@joeyparrish joeyparrish merged commit d4fcfb2 into shaka-project:cmake Jul 13, 2023
@joeyparrish joeyparrish deleted the add-mongoose branch July 13, 2023 23:36
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Sep 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants