Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adaptation set IDs were referenced by lowest representation ID #1394

Merged
merged 1 commit into from
May 11, 2024

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented May 7, 2024

After change to add forced command line ordering adaptation set IDs in places were referenced by their sort index (the minimum representation index they contained).

Instead always refer to adaptation sets by their own ID, and use the index only as an optional sort key.

Fixes #1393

@cosmin cosmin requested a review from joeyparrish May 7, 2024 00:56
@cosmin cosmin added this to the v3.2 milestone May 7, 2024
@cosmin cosmin merged commit 94db9c9 into shaka-project:main May 11, 2024
36 checks passed
@cosmin cosmin deleted the fix-adaptation-sets-ids branch May 11, 2024 00:24
cosmin pushed a commit that referenced this pull request May 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.2.0](v3.1.0...v3.2.0)
(2024-05-11)


### Features

* support Dolby Vision profile 8.x (HEVC) and 10.x (AV1) in HLS and DASH
([#1396](#1396))
([a99cfe0](a99cfe0))


### Bug Fixes

* adaptation set IDs were referenced by lowest representation ID
([#1394](#1394))
([94db9c9](94db9c9)),
closes
[#1393](#1393)
* escape media URLs in MPD
([#1395](#1395))
([98b44d0](98b44d0))
* set yuv full range flag to 1 for VP9 with sRGB
([#1398](#1398))
([f6f60e5](f6f60e5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packager Adaptation Set Switching values point to representation IDs instead of Adaptation Set IDs.
2 participants