Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NPM Exports #34

Closed
palmerj3 opened this issue Mar 11, 2015 · 2 comments
Closed

Add NPM Exports #34

palmerj3 opened this issue Mar 11, 2015 · 2 comments
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request

Comments

@palmerj3
Copy link
Contributor

I would like for you to create a file index.js in the root of the project that contains the proper module.exports for all of the major classes for shaka-player.

Currently the NPM dependency requires google closure compiler in order to be used and the individual namespaced classes are only available after including the script in head or .

Exposing module.exports would allow this lib to be used in a CommonJS environment more easily.

@palmerj3
Copy link
Contributor Author

I've created a PR for this feature - please review when you have the chance. Thanks!

#35

@joeyparrish joeyparrish added the type: enhancement New feature or request label Mar 12, 2015
@joeyparrish
Copy link
Member

Closing now that #35 is merged. Thanks!

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants