feat(HLS): Add support for EXT-X-SESSION-KEY tag #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 95.92% |
avelad
added
type: enhancement
avelad
added
the
priority: P1
avelad
force-pushed
the
ext-x-session-key
branch
from
e1a9fb1
to
21a877a
Compare
joeyparrish
requested changes
Nov 7, 2022
theodab
previously approved these changes
Nov 8, 2022
joeyparrish
requested changes
Nov 8, 2022
test/hls/hls_parser_unit.js
Outdated
| expect(actual).toEqual(manifest); | ||
| }); | ||
|
|
||
| it('with match characteristics', async () => { |
There was a problem hiding this comment.
I think this test is obsolete now that you've removed the code that tried to optimize with characteristics.
joeyparrish
approved these changes
Nov 8, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #917