Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support HTML-escaped cues in VTT #4660

Merged
merged 4 commits into from
Nov 10, 2022
Merged

feat: Support HTML-escaped cues in VTT #4660

merged 4 commits into from
Nov 10, 2022

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 8, 2022

No description provided.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: WebVTT The issue involves WebVTT subtitles specifically labels Nov 8, 2022
@avelad avelad added this to the v4.3 milestone Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022 •
edited
Loading

Incremental code coverage: 100.00%

theodab
theodab previously requested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make a new test in vtt_text_parser_unit.js.

lib/text/vtt_text_parser.js Outdated Show resolved Hide resolved
lib/text/vtt_text_parser.js Outdated Show resolved Hide resolved
lib/text/vtt_text_parser.js Show resolved Hide resolved
@avelad avelad requested a review from theodab November 8, 2022 19:18
@joeyparrish joeyparrish changed the title feat: Add support to escaped cues in VttTextParser feat: Support HTML-escaped cues in VTT Nov 10, 2022
@joeyparrish joeyparrish merged commit 2b8b387 into shaka-project:main Nov 10, 2022
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Merged
@avelad avelad deleted the vtt-escaped-html branch November 10, 2022 10:22
joeyparrish added a commit that referenced this pull request Jan 30, 2023
@avelad @joeyparrish
fix(WebVTT): Add support to  , ‎ and ‏ (#4920)
3fa6ff0 
Backported to v4.2.x, also includes #4660

Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish added a commit that referenced this pull request Jan 30, 2023
@avelad @joeyparrish
fix(WebVTT): Add support to &nbsp;, &lrm; and &rlm; (#4920)
b9ddf6a 
Backported to v4.2.x, also includes #4660

Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish added a commit that referenced this pull request Jan 30, 2023
@avelad @joeyparrish
fix(WebVTT): Add support to &nbsp;, &lrm; and &rlm; (#4920)
ff36a0a 
Backported to v4.2.x, also includes #4660

Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @joeyparrish @theodab