Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaka Player TextTrack - console.log since 4.4.0 #5581

Closed
francoism90 opened this issue Sep 1, 2023 · 2 comments · Fixed by #5582
Closed

Shaka Player TextTrack - console.log since 4.4.0 #5581

francoism90 opened this issue Sep 1, 2023 · 2 comments · Fixed by #5582
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@francoism90
Copy link
Contributor

What version of Shaka Player are you using?
4.4.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
No, the demos seem to be running fine.

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
No

What browser and OS are you using?
Firefox, Linux

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
N/A

What configuration are you using? What is the output of player.getConfiguration()?
N/A

What did you do?
I'm using this in Laravel (Vite):

import shaka from 'shaka-player/dist/shaka-player.ui'

shaka.polyfill.installAll()

window.shaka = shaka

What did you expect to happen?
No logging

What actually happened?
It happens after upgrading to 4.4.0, something seems to be logging, but I cannot find the console.log in the Shaka code?
Downgrading to the previous release, fixes the issue.

The following messages are being logged in console:

TextTrack { kind: "subtitles", label: "Shaka Player TextTrack", language: "", id: "" ...

This is a part of the compiled source using Vite:

(Array.from(e.textTracks)),n=t.next();!n.done;n=t.next())n=n.value,n.mode="disabled",n.label=="Shaka Player TextTrack"&&(this.g=n);this.g||(this.g=e.addTextTrack("subtitles","Shaka Player TextTrack"),console.log(this.g)),this.g.mode="hidden"}

Thanks

@francoism90 francoism90 added the type: bug Something isn't working correctly label Sep 1, 2023
@github-actions github-actions bot added this to the v4.5 milestone Sep 1, 2023
avelad pushed a commit that referenced this issue Sep 1, 2023
@francoism90
Copy link
Contributor Author

francoism90 commented Sep 5, 2023

@avelad It seems the package on NPM hasn't been updated/bump.

Sorry to tag you, I can open an issue if you want.

https://www.npmjs.com/package/shaka-player?activeTab=versions

@avelad
Copy link
Member

avelad commented Sep 5, 2023

Please, open a new issue!

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 31, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 31, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants