Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove debugging code on Simple Text #5582

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: Remove debugging code on Simple Text #5582

merged 1 commit into from
Sep 1, 2023

Conversation

francoism90
Copy link
Contributor

@francoism90 francoism90 commented Sep 1, 2023

Fixes #5581

@google-cla
Copy link

google-cla bot commented Sep 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@francoism90 francoism90 changed the title Remove debugging code fix: Remove debugging code on Simple Text Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Incremental code coverage: No instrumented code was changed.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 1, 2023
@avelad avelad added this to the v4.5 milestone Sep 1, 2023
@avelad avelad merged commit 991130a into shaka-project:main Sep 1, 2023
18 of 20 checks passed
joeyparrish pushed a commit that referenced this pull request Sep 2, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 31, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shaka Player TextTrack - console.log since 4.4.0
3 participants