perf: Optimization to resolve uris #5657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: performance
joeyparrish
approved these changes
Sep 14, 2023
| .map((base) => relativeAsGoog.map((i) => base.resolve(i))) | ||
| .reduce(Functional.collapseArrays, []) | ||
| .map((uri) => uri.toString()); | ||
| return baseUris.map((uri) => { |
There was a problem hiding this comment.
Would it help performance to rewrite this as a loop with no functional callbacks?
There was a problem hiding this comment.
I don't see any difference using loops
joeyparrish
pushed a commit
that referenced
this pull request
Sep 14, 2023
Chained use of maps and reduce on legacy devices reduces performance. So if there is only one url to generate we can optimize performance.
joeyparrish
pushed a commit
that referenced
this pull request
Sep 14, 2023
Chained use of maps and reduce on legacy devices reduces performance. So if there is only one url to generate we can optimize performance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chained use of maps and reduce on legacy devices reduces performance. So if there is only one url to generate we can optimize performance.