perf: simplify and improve performance of parsing initData when deduping #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
changed the title
avelad
added
type: performance
vanyaxk
force-pushed
the
refactor/avoid-unnecessary-complexity-when-comparing-init-data
branch
from
59b705a to
d365049
Compare
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Oct 19, 2023
theodab
requested changes
Oct 21, 2023
| for (const d of bothInitDatas) { | ||
| if (typeof d !== 'string' && !initDataMap.has(d.keyId)) { | ||
| initDataMap.set(d.keyId, d); | ||
| } else if (typeof d === 'string' && !initDataMap.has(d)) { |
There was a problem hiding this comment.
Perhaps I'm forgetting something. In what situations are we expecting the initData array of the drm to contain a string instead of a shaka.extern.InitDataOverride? The previous version of this code did not seem to account for that.
There was a problem hiding this comment.
I had to take this into account as not doing so breaks one of the tests where there is indeed a string in initData which I reckoned there is a reason behind
There was a problem hiding this comment.
I see. That's annoying. We shouldn't have tests like that.
In that case I'll approve this, and then just quickly go and make a PR to change those tests.
theodab
approved these changes
Oct 22, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
…ing (shaka-project#5775) This change simplifies code that parses initData in the `getCommonDrmInfos` method Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies code that parses initData in the
getCommonDrmInfosmethod