Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add thumbnails support in src= #5802

Merged
merged 1 commit into from
Oct 26, 2023
Merged

feat: Add thumbnails support in src= #5802

merged 1 commit into from
Oct 26, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 24, 2023

Closes #5778

@avelad avelad added type: enhancement New feature or request priority: P4 Nice to have / wishful thinking labels Oct 24, 2023
@avelad avelad added this to the v4.6 milestone Oct 24, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 92.68%

theodab
theodab approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git diff is a bit hard to read, but that is basically what I was imagining, yeah.

@avelad avelad merged commit 88e4cd4 into shaka-project:main Oct 26, 2023
@shaka-bot shaka-bot mentioned this pull request Oct 26, 2023
Merged
@avelad avelad deleted the thumbnails-src branch October 26, 2023 06:17
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat: Add thumbnails support in src= (shaka-project#5802)
004a43a 
Closes shaka-project#5778
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 25, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Support addThumbnailsTrack in SRC_EQUALS
3 participants
@avelad @shaka-bot @theodab