Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix nalu parsing and improve performance in the transmuxer #5846

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: Fix nalu parsing and improve performance in the transmuxer #5846

merged 1 commit into from
Nov 2, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 2, 2023 •
edited
Loading

Fixes #5666
Fixes #5797

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 2, 2023
@avelad avelad marked this pull request as draft November 2, 2023 11:35
@avelad avelad added this to the v4.6 milestone Nov 2, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Nov 2, 2023 •
edited
Loading

Incremental code coverage: 65.60%

@avelad avelad marked this pull request as ready for review November 2, 2023 14:22
@avelad avelad merged commit ae423b4 into shaka-project:main Nov 2, 2023
20 of 32 checks passed
@avelad avelad deleted the transmuxer-improvements branch November 2, 2023 16:55
@shaka-bot shaka-bot mentioned this pull request Nov 2, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix: Fix nalu parsing and improve performance in the transmuxer (shak…
cc9dff9 
…a-project#5846)

Fixes shaka-project#5666
Fixes shaka-project#5797
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 1, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Live stream jumps and freezes HLS Live stream repeateatable rebuffering/seeking regression
3 participants
@avelad @shaka-bot @littlespex