Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config to ignore duplicate init data #5853

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 3, 2023

Closes #4572

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Nov 3, 2023
@avelad avelad added this to the v4.6 milestone Nov 3, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit acf23f8 into shaka-project:main Nov 3, 2023
19 of 20 checks passed
@avelad avelad deleted the duplicate-init-data branch November 3, 2023 15:02
*
* @property {boolean} ignoreDuplicateInitData
* <i>Defaults to false on Tizen 2, and true for all other browsers.</i><br>
* When true indicate that the player doesn't ignore duplicate init data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be "When true indicates that the player does ignore duplicate init data". (Without negation)

Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 2, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable logic to decision to ignore duplicate init data
4 participants