Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): decrease memory preasure on manifest with SegmentReference by updating old initSegmentReference #6499

Merged
merged 2 commits into from
Apr 29, 2024
Merged

fix(DASH): decrease memory preasure on manifest with SegmentReference by updating old initSegmentReference #6499

merged 2 commits into from
Apr 29, 2024

Conversation

cdatehortuab
Copy link
Contributor

Helps on #6070

@cristian-atehortua cristian-atehortua mentioned this pull request Apr 29, 2024
Closed
@avelad avelad added type: bug Something isn't working correctly type: performance A performance issue priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Apr 29, 2024
@avelad avelad added this to the v4.9 milestone Apr 29, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 96.15%

@joeyparrish joeyparrish merged commit 2dd85e4 into shaka-project:main Apr 29, 2024
12 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 29, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Apr 29, 2024
@cdatehortuab @joeyparrish
fix(DASH): decrease memory preasure on manifest with SegmentReference…
ad6944f 
… by updating old initSegmentReference (#6499)

Helps on #6070
@shaka-bot shaka-bot mentioned this pull request Apr 29, 2024
Merged
@tra83
Copy link

tra83 commented Apr 30, 2024

Is there any plans on including this to 4.6.x ?

@avelad
Copy link
Member

avelad commented Apr 30, 2024

@tra83 4.6.x is no longer maintained with the release of 4.8. You can see the maintained branches at https://github.com/shaka-project/shaka-player/blob/main/maintained-branches.md

joeyparrish pushed a commit that referenced this pull request May 7, 2024
@cdatehortuab @joeyparrish
fix(DASH): decrease memory preasure on manifest with SegmentReference…
3e5f98d 
… by updating old initSegmentReference (#6499)

Helps on #6070

Backported to v4.7.x
@shaka-bot shaka-bot mentioned this pull request May 7, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 7, 2024
@cdatehortuab @joeyparrish
fix(DASH): decrease memory preasure on manifest with SegmentReference…
4df22d2 
… by updating old initSegmentReference (#6499)

Helps on #6070

Backported to v4.7.x
@shaka-bot shaka-bot mentioned this pull request May 7, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: performance A performance issue
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.
5 participants
@cdatehortuab @shaka-bot @tra83 @avelad @joeyparrish