Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xbox - round gap jumping values #6695

Merged
merged 3 commits into from
May 29, 2024

Conversation

tykus160
Copy link
Member

It looks like Xbox incorrectly rounds values to seek and it's not able to jump over gaps sometimes.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: Xbox Issues affecting Xbox labels May 29, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented May 29, 2024

Incremental code coverage: 83.33%

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@avelad
Copy link
Member

avelad commented May 29, 2024

@tykus160 Can you fix the lint errors?

@avelad avelad added this to the v4.9 milestone May 29, 2024
@avelad avelad merged commit 5b6e340 into shaka-project:main May 29, 2024
15 checks passed
avelad added a commit that referenced this pull request May 29, 2024
It looks like Xbox incorrectly rounds values to seek and it's not able
to jump over gaps sometimes.

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@tykus160 tykus160 deleted the wt-xbox-gap-upstream branch May 29, 2024 14:24
joeyparrish pushed a commit that referenced this pull request May 31, 2024
It looks like Xbox incorrectly rounds values to seek and it's not able
to jump over gaps sometimes.

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 28, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: Xbox Issues affecting Xbox priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants