Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add segment URIs to segment-related errors #6714

Merged
merged 2 commits into from
May 31, 2024

Conversation

joeyparrish
Copy link
Member

This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes #6712

This makes it more feasible to debug and fix transmuxer bugs or other
segment append failures.

Closes shaka-project#6712
@joeyparrish joeyparrish requested review from littlespex and avelad May 30, 2024 22:19
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 45.80%

@avelad avelad changed the title fix: Add segment URIs to segment-related errors feat: Add segment URIs to segment-related errors May 31, 2024
@avelad avelad added type: enhancement New feature or request priority: P2 Smaller impact or easy workaround labels May 31, 2024
@avelad avelad added this to the v4.10 milestone May 31, 2024
@joeyparrish joeyparrish merged commit 8d680e5 into shaka-project:main May 31, 2024
17 of 18 checks passed
@joeyparrish joeyparrish deleted the add-segment-to-errors branch May 31, 2024 16:41
joeyparrish added a commit that referenced this pull request May 31, 2024
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes #6712
joeyparrish added a commit that referenced this pull request May 31, 2024
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes #6712
tykus160 pushed a commit to sky-hugolima/shaka-player-contrib that referenced this pull request Jun 3, 2024
This makes it more feasible to debug and fix transmuxer bugs or other segment append failures.

Closes shaka-project#6712
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 30, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add segment URL to segment-related error codes
3 participants