Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): UI does not update after loading a new stream #6721

Merged
merged 1 commit into from
May 31, 2024
Merged

fix(UI): UI does not update after loading a new stream #6721

merged 1 commit into from
May 31, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 31, 2024

Fixes #6720

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels May 31, 2024
@avelad avelad added this to the v4.10 milestone May 31, 2024
@avelad avelad requested review from joeyparrish and theodab May 31, 2024 10:44
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad mentioned this pull request May 31, 2024
Closed
@avelad avelad merged commit d9242cd into shaka-project:main May 31, 2024
19 of 20 checks passed
@shaka-bot shaka-bot mentioned this pull request May 31, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 31, 2024
@avelad @joeyparrish
fix(UI): UI does not update after loading a new stream (#6721)
6d9ddb1 
Fixes #6720
@shaka-bot shaka-bot mentioned this pull request May 31, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 31, 2024
@avelad @joeyparrish
fix(UI): UI does not update after loading a new stream (#6721)
a131203 
Fixes #6720
@shaka-bot shaka-bot mentioned this pull request May 31, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 31, 2024
@avelad @joeyparrish
fix(UI): UI does not update after loading a new stream (#6721)
839b550 
Fixes #6720
joeyparrish pushed a commit that referenced this pull request May 31, 2024
@avelad @joeyparrish
fix(UI): UI does not update after loading a new stream (#6721)
bf05413 
Fixes #6720
@avelad avelad deleted the ui-update-on-load branch June 3, 2024 06:59
tykus160 pushed a commit to sky-hugolima/shaka-player-contrib that referenced this pull request Jun 3, 2024
@avelad @tykus160
fix(UI): UI does not update after loading a new stream (shaka-project…
0ace812 
…#6721)

Fixes shaka-project#6720
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 30, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.

UI not updates/refreshes after loading a new file.
3 participants
@avelad @shaka-bot @joeyparrish