Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Add content resume/pause requested events #6738

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 3, 2024

This change simplifies the integration of HLS interstitials on platforms that do not support multiple video elements.

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Jun 3, 2024
@avelad avelad added this to the v4.10 milestone Jun 3, 2024
@avelad
Copy link
Member Author

avelad commented Jun 3, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6738

@avelad avelad force-pushed the ad-preload-simplicity branch from ddf157a to 3a8c792 Compare June 3, 2024 10:46
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad requested review from joeyparrish and theodab June 3, 2024 11:49
@avelad avelad merged commit 9b47b8f into shaka-project:main Jun 4, 2024
31 of 32 checks passed
@avelad avelad deleted the ad-preload-simplicity branch June 4, 2024 06:45
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants