Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not export functions in getNonDefaultConfiguration #6739

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 3, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jun 3, 2024
@avelad avelad added this to the v4.10 milestone Jun 3, 2024
@avelad avelad requested review from joeyparrish and theodab June 3, 2024 15:18
@avelad
Copy link
Member Author

avelad commented Jun 3, 2024

This is necessary for interstitials to be able to pass the configuration to admanger and make it secure.

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 93c6123 into shaka-project:main Jun 4, 2024
18 of 19 checks passed
@avelad avelad deleted the getNonDefaultConfiguration-fix branch June 4, 2024 06:12
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants