feat(Ads): Add support for interstitials when using src= #6777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
avelad
commented
Jun 10, 2024
| if (this.basePlayer_.getLoadMode() == shaka.Player.LoadMode.SRC_EQUALS && | ||
| this.usingBaseVideo_) { | ||
| shaka.log.alwaysWarn( | ||
| 'Unsupported interstitial when using single media element', |
There was a problem hiding this comment.
This is necessary because our system to only use one video depends on the preload api and there is no fallback for src=
tykus160
reviewed
Jun 10, 2024
|
Incremental code coverage: 16.22% |
theodab
approved these changes
Jun 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.