Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Add CUE PRE and POST support in Interstitials #6799

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 11, 2024

No description provided.

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Jun 11, 2024
@avelad avelad added this to the v4.10 milestone Jun 11, 2024
@avelad avelad changed the title feat(Ads): Add CUE PRE and POST support in Interstitials feat(Ads): Add CUE PRE and POST support in Interstitials Jun 11, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 11, 2024

Incremental code coverage: 87.04%

@avelad
Copy link
Member Author

avelad commented Jun 11, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6799

@avelad avelad requested review from joeyparrish and theodab June 11, 2024 15:18
lib/ads/interstitial_ad_manager.js Outdated Show resolved Hide resolved
@avelad avelad requested review from theodab and removed request for theodab June 12, 2024 09:23
@avelad avelad merged commit 4ea9a44 into shaka-project:main Jun 12, 2024
15 of 16 checks passed
@avelad avelad deleted the interstitials-cue-pre-post branch June 12, 2024 09:51
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 11, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants