fix: ignore buffered content less than 1e-4s #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Firefox, in some cases after a period ends, seeking shortly after will cause playback to fail or stall. This occurs when the next period has small gaps and we're seeking to after the gap. Seeking to before the gap succeeds. Even though the seek requests the soure buffers to be fully cleared, Firefox actually keeps around less than 1e-4s of content and won't let us forcibly remove this content. Trying to call flush causes in infinite loop. This leftover content makes shaka think that the buffer end in where we used to be even though the presentation time reflects where we seeked to. This means that playback doesn't continue. The buffer contitues getting filled and playback will either fail when the SourcBuffer is filled and triggers a QuotaExceededError or contiue when the buffer will reach the presentationTime.
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
tykus160
reviewed
Jun 12, 2024
lib/media/time_ranges_utils.js
Outdated
| @@ -23,7 +23,8 @@ shaka.media.TimeRangesUtils = class { | |||
| return null; | |||
| } | |||
| // Workaround Safari bug: https://bit.ly/2trx6O8 | |||
| if (b.length == 1 && b.end(0) - b.start(0) < 1e-6) { | |||
| // Firefox may leave <1e-4s of data in buffer after clearing all content | |||
| if (b.length == 1 && b.end(0) - b.start(0) < 1e-4) { | |||
There was a problem hiding this comment.
There are lots of those checks... Maybe move it to some util function so in the future we will not be forced to change the same value all over the place?
There was a problem hiding this comment.
Yes, I agree, please move the check to a helper function or at least move the value to a constant. Thanks!
avelad
requested changes
Jun 12, 2024
lib/media/time_ranges_utils.js
Outdated
| @@ -23,7 +23,8 @@ shaka.media.TimeRangesUtils = class { | |||
| return null; | |||
| } | |||
| // Workaround Safari bug: https://bit.ly/2trx6O8 | |||
| if (b.length == 1 && b.end(0) - b.start(0) < 1e-6) { | |||
| // Firefox may leave <1e-4s of data in buffer after clearing all content | |||
| if (b.length == 1 && b.end(0) - b.start(0) < 1e-4) { | |||
There was a problem hiding this comment.
Yes, I agree, please move the check to a helper function or at least move the value to a constant. Thanks!
avelad
approved these changes
Jun 12, 2024
tykus160
approved these changes
Jun 12, 2024
joeyparrish
approved these changes
Jun 12, 2024
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2024
On Firefox, in some cases after a period ends, seeking shortly after will cause playback to fail or stall. This occurs when the next period has small gaps and we're seeking to after the gap. Seeking to before the gap succeeds. Even though the seek requests the soure buffers to be fully cleared, Firefox actually keeps around less than 1e-4s of content and won't let us forcibly remove this content. Trying to call flush causes in infinite loop. This leftover content makes shaka think that the buffer end in where we used to be even though the presentation time reflects where we seeked to. This means that playback doesn't continue. The buffer contitues getting filled and playback will either fail when the SourcBuffer is filled and triggers a QuotaExceededError or contiue when the buffer will reach the presentationTime.
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2024
On Firefox, in some cases after a period ends, seeking shortly after will cause playback to fail or stall. This occurs when the next period has small gaps and we're seeking to after the gap. Seeking to before the gap succeeds. Even though the seek requests the soure buffers to be fully cleared, Firefox actually keeps around less than 1e-4s of content and won't let us forcibly remove this content. Trying to call flush causes in infinite loop. This leftover content makes shaka think that the buffer end in where we used to be even though the presentation time reflects where we seeked to. This means that playback doesn't continue. The buffer contitues getting filled and playback will either fail when the SourcBuffer is filled and triggers a QuotaExceededError or contiue when the buffer will reach the presentationTime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Firefox, in some cases after a period ends, seeking shortly after will cause playback to fail or stall.
This occurs when the next period has small gaps and we're seeking to after the gap. Seeking to before the gap succeeds. Even though the seek requests the soure buffers to be fully cleared, Firefox actually keeps around less than 1e-4s of content and won't let us forcibly remove this content. Trying to call flush causes in infinite loop.
This leftover content makes shaka think that the buffer end in where we used to be even though the presentation time reflects where we seeked to. This means that playback doesn't continue. The buffer contitues getting filled and playback will either fail when the SourcBuffer is filled and triggers a QuotaExceededError or contiue when the buffer will reach the presentationTime.