Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix audio properties detection #6867

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 19, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jun 19, 2024
@avelad avelad added this to the v4.10 milestone Jun 19, 2024
@avelad avelad requested review from joeyparrish and theodab June 19, 2024 09:56
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 19, 2024

Incremental code coverage: 78.79%

lib/media/segment_utils.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab June 20, 2024 06:21
@avelad avelad merged commit e204bf6 into shaka-project:main Jun 20, 2024
15 of 16 checks passed
@avelad avelad deleted the audio-detection branch June 20, 2024 06:45
avelad added a commit that referenced this pull request Jun 20, 2024
avelad added a commit that referenced this pull request Jun 20, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 19, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants