Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Remove circular dependency #6868

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 19, 2024

To eliminate * @suppress {missingRequire} it was necessary to create a new class with the constants and deprecate the old ones. That's why this change is feat.

@avelad avelad requested review from joeyparrish and theodab June 19, 2024 10:42
@avelad avelad added type: enhancement New feature or request type: code health A code health issue component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Jun 19, 2024
@avelad avelad added this to the v4.10 milestone Jun 19, 2024
@avelad
Copy link
Member Author

avelad commented Jun 19, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6868

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 64.10%

@avelad avelad merged commit e39defb into shaka-project:main Jun 20, 2024
35 of 36 checks passed
@avelad avelad deleted the circular-dependency branch June 20, 2024 06:11
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 19, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: code health A code health issue type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants