fix: Only request initialization segment when it's necessary #6929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaka-bot test |
avelad
added
type: bug
|
@avelad: Lab tests started with arguments:
|
avelad
force-pushed
the
seek-init-segment
branch
from
ca4a0a7 to
68ee757
Compare
|
Incremental code coverage: No instrumented code was changed. |
theodab
approved these changes
Jun 28, 2024
avelad
added a commit
that referenced
this pull request
Jul 1, 2024
According to https://w3c.github.io/media-source/#dom-sourcebuffer-remove Deleting a range from the source buffer does not delete the initialization segment, so this change will prevent the initialization segment from being requested when it is not needed.
avelad
added a commit
that referenced
this pull request
Jul 1, 2024
According to https://w3c.github.io/media-source/#dom-sourcebuffer-remove Deleting a range from the source buffer does not delete the initialization segment, so this change will prevent the initialization segment from being requested when it is not needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://w3c.github.io/media-source/#dom-sourcebuffer-remove
Deleting a range from the source buffer does not delete the initialization segment, so this change will prevent the initialization segment from being requested when it is not needed.