fix(Ads): Always fire CUEPOINTS_CHANGED when not using multi video elements #7584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements This is necessary because in our UI when reusing the same video element the unloading event is launched and we clear the cuepoints with that event.
avelad
added
type: bug
joeyparrish
changed the title
joeyparrish
approved these changes
Nov 13, 2024
This was referenced Nov 13, 2024
avelad
added a commit
that referenced
this pull request
Nov 15, 2024
…ements (#7584) This is necessary because in our UI when reusing the same video element the unloading event is launched and we clear the cuepoints with that event.
avelad
added a commit
that referenced
this pull request
Nov 15, 2024
…ements (#7584) This is necessary because in our UI when reusing the same video element the unloading event is launched and we clear the cuepoints with that event.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because in our UI when reusing the same video element the unloading event is launched and we clear the cuepoints with that event.