Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix parameters lost during codec switch #7630

Merged

Conversation

dpfister2
Copy link
Contributor

@dpfister2 dpfister2 commented Nov 19, 2024

Caches source buffer parameters on codec switch with the RELOAD configuration

Fixes #7555

BEGIN_COMMIT_OVERRIDE
fix: Fix parameters lost during codec switch (#7630)
END_COMMIT_OVERRIDE

@tykus160 tykus160 added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 19, 2024
@tykus160 tykus160 added this to the v4.13 milestone Nov 19, 2024
@joeyparrish
Copy link
Member

@shaka-bot please test

@shaka-bot
Copy link
Collaborator

@joeyparrish: Lab tests started with arguments:

  • pr=7630

@joeyparrish joeyparrish merged commit 7837b60 into shaka-project:main Nov 19, 2024
38 checks passed
@joeyparrish joeyparrish changed the title fix: cache source buffer params on codec switch reload fix: Fix parameters lost during codec switch Nov 19, 2024
joeyparrish pushed a commit that referenced this pull request Nov 19, 2024
Caches source buffer parameters on codec switch with the RELOAD
configuration

Fixes #7555
joeyparrish pushed a commit that referenced this pull request Nov 19, 2024
Caches source buffer parameters on codec switch with the RELOAD
configuration

Fixes #7555
joeyparrish pushed a commit that referenced this pull request Nov 19, 2024
Caches source buffer parameters on codec switch with the RELOAD
configuration

Fixes #7555
@tykus160 tykus160 deleted the dpfister2-cache-buffer-params branch November 29, 2024 10:40
tykus160 added a commit to sky-hugolima/shaka-player-contrib that referenced this pull request Dec 2, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 18, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video Source Buffer Params Lost During Audio Codec Switch Reload
6 participants