-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix parameters lost during codec switch #7630
Merged
joeyparrish
merged 1 commit into
shaka-project:main
from
sky-hugolima:dpfister2-cache-buffer-params
Nov 19, 2024
Merged
fix: Fix parameters lost during codec switch #7630
joeyparrish
merged 1 commit into
shaka-project:main
from
sky-hugolima:dpfister2-cache-buffer-params
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykus160
added
type: bug
Something isn't working correctly
priority: P1
Big impact or workaround impractical; resolve before feature release
labels
Nov 19, 2024
gkatsev
approved these changes
Nov 19, 2024
@shaka-bot please test |
joeyparrish
approved these changes
Nov 19, 2024
@joeyparrish: Lab tests started with arguments:
|
tykus160
approved these changes
Nov 19, 2024
theodab
approved these changes
Nov 19, 2024
joeyparrish
changed the title
fix: cache source buffer params on codec switch reload
fix: Fix parameters lost during codec switch
Nov 19, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Nov 19, 2024
Caches source buffer parameters on codec switch with the RELOAD configuration Fixes #7555
joeyparrish
pushed a commit
that referenced
this pull request
Nov 19, 2024
Caches source buffer parameters on codec switch with the RELOAD configuration Fixes #7555
joeyparrish
pushed a commit
that referenced
this pull request
Nov 19, 2024
Caches source buffer parameters on codec switch with the RELOAD configuration Fixes #7555
This was referenced Nov 19, 2024
tykus160
added a commit
to sky-hugolima/shaka-player-contrib
that referenced
this pull request
Dec 2, 2024
…-project#7630)" This reverts commit 7837b60.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches source buffer parameters on codec switch with the RELOAD configuration
Fixes #7555
BEGIN_COMMIT_OVERRIDE
fix: Fix parameters lost during codec switch (#7630)
END_COMMIT_OVERRIDE