Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails do not show, getImageTracks returns empty list when not supposed to #7639

Open
radiantmediaplayer opened this issue Nov 20, 2024 · 1 comment
Labels
status: waiting on response Waiting on a response from the reporter(s) of the issue status: working as intended The behavior is intended; this is not a bug

Comments

@radiantmediaplayer
Copy link

Have you read the FAQ and checked for duplicate open issues?
Y

If the problem is related to FairPlay, have you read the tutorial?
N

What version of Shaka Player are you using?
4.12.1, 4.11.13, 4.7.15

Can you reproduce the issue with our latest release version?
Y

Can you reproduce the issue with the latest code from main?
Y

Are you using the demo app or your own custom app?
Demo

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Latest Chrome for Windows 11

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
Do NOT work:
https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_4_tiles_thumbnails.mpd
https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails_2.mpd
https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_multiple_tiled_thumbnails.mpd

Do work:
https://dash.akamaized.net/akamai/bbb_30fps/bbb_with_tiled_thumbnails.mpd
https://livesim2.dashif.org/livesim2/testpic_2s/Manifest_thumbs.mpd

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?
Default from demo page

What did you do?
Go to https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=ALL_CONTENT;build=uncompiled and apply "Thumbnails" filter, try to play content and hover seek bar to see Thumbnails.
DASH-IF THUMBNAILS - Single adaptation set, 7 tiles at 10x1, each thumb 320x180 > show Thumbnails
DASH-IF THUMBNAILS - Single adaptation set, 4 tiles at 10x1, each thumb 205x115 > DO NOT show Thumbnails
DASH-IF THUMBNAILS - Single adaptation set, 1 tile at 10x20, each thumb 102x58 > DO NOT show Thumbnails
DASH-IF THUMBNAILS - Two adaptation sets with different thumb resolutions > DO NOT show Thumbnails
DASH-IF THUMBNAILS - Live stream, Single adaptation set, 1x1 tiles (livesim) > show Thumbnails

What did you expect to happen?
Thumbnails should be shown in all cases over the seek bar when hovered.

What actually happened?
In version 4.7.15 all Thumbnails are shown and getImageTracks return a valid list. With version 4.11.* and 4.12.* getImageTracks sometimes return an empty list when Thumbnails should be present. Is it a regression or do I need to do something different?

Are you planning send a PR to fix it?
N

@radiantmediaplayer radiantmediaplayer added the type: bug Something isn't working correctly label Nov 20, 2024
@shaka-bot shaka-bot added this to the v4.13 milestone Nov 20, 2024
@avelad
Copy link
Member

avelad commented Nov 20, 2024

The change was introduced at bbefead

These non-working assets use float durations, which is not what the spec allows.

@avelad avelad added status: working as intended The behavior is intended; this is not a bug and removed type: bug Something isn't working correctly labels Nov 20, 2024
@avelad avelad removed this from the v4.13 milestone Nov 20, 2024
@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting on response Waiting on a response from the reporter(s) of the issue status: working as intended The behavior is intended; this is not a bug
Projects
None yet
Development

No branches or pull requests

3 participants