feat(Ads): Add support for overlay interstitials (or non-linear ads) #7657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
theodab
approved these changes
Nov 25, 2024
| @@ -116,10 +118,39 @@ shaka.extern.AdCuePoint; | |||
| * @property {boolean} timelineRange | |||
| * Indicates whether the interstitial should be presented in a timeline UI | |||
| * as a single point or as a range. | |||
| * @property {boolean} loop | |||
| * Indicates that the interstitials should play in loop. | |||
| * Only applies if the interstitials is an overlay. | |||
There was a problem hiding this comment.
Hm. I'm wondering if it would make more sense to make this be part of the shaka.extern.AdInterstitialOverlay structure. It's not logically a part of the overlay, but if it's only meant to be used when we are also using an overlay it might reduce confusion to move it into that structure...
Honestly, I'm undecided here.
There was a problem hiding this comment.
I have the same question, but would anyone like to put a normal 1s interstitial with a loop and a 15 second limit to avoid downloading longer and heavier segments and simplify the logic. I'm looking to see if anyone has that requirement, that's why it's out right now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.