fix: Fix support for supplemental codecs (Dolby Vision) #7720
+72
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
force-pushed
the
fix-supplemental-codecs
branch
from
da9b144 to
187f583
Compare
avelad
force-pushed
the
fix-supplemental-codecs
branch
from
187f583 to
e4d15ad
Compare
|
Incremental code coverage: 100.00% |
theodab
requested changes
Dec 9, 2024
tykus160
requested changes
Dec 9, 2024
Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
theodab
approved these changes
Dec 9, 2024
tykus160
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work of @gmcgarry Thank you very much!
Currently the codec adds supplemental codecs to the list of allCodecs and has an implicit priority order to select a codec. Support for the codec is tested with MediaSource.isTypeSupported().
There are multiple issues with this approach:
This patch duplicates the variant with each supplemental codec and defers codec priority and codec selection until after MediaCapabilities.decodingInfo().
This fixes support for DolbyVision Profile 8, which is otherwise broken because the chromium browsers always return false from MediaSource.isTypeSupported(), and DolbyVision is commonly only available in a secure hardware decode pipeline.
Note: Safari does not have this problem since it supports Dolby Vision in clear