Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Ads): Remove iframe border in overlays #7738

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(Ads): Remove iframe border in overlays #7738

merged 1 commit into from
Dec 11, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 10, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Dec 10, 2024
@avelad avelad added this to the v4.13 milestone Dec 10, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 0.00%

@avelad avelad merged commit 60c88eb into shaka-project:main Dec 11, 2024
22 of 23 checks passed
@shaka-bot shaka-bot mentioned this pull request Dec 11, 2024
Merged
@avelad avelad deleted the border-iframe branch December 11, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @joeyparrish