Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove useless deprecation in UITextDisplayer and add some guards in SimpleTextDisplayer #7805

Merged
merged 1 commit into from
Dec 24, 2024
Merged

fix: Remove useless deprecation in UITextDisplayer and add some guards in SimpleTextDisplayer #7805

merged 1 commit into from
Dec 24, 2024
+14 −22

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 24, 2024

Fixes #7803

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Dec 24, 2024
@avelad avelad added this to the v4.13 milestone Dec 24, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 81.82%

theodab
theodab approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I'm not super happy with the PR name, but I guess I can't think of a more succinct way to describe this than a "removing a useless deprecation". So it's probably fine.

@avelad avelad merged commit fd78ec4 into shaka-project:main Dec 24, 2024
24 of 25 checks passed
@shaka-bot shaka-bot mentioned this pull request Dec 24, 2024
Open
@avelad avelad deleted the subtitle-errors branch December 24, 2024 12:03
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
@avelad @joeyparrish
fix: Remove useless deprecation in UITextDisplayer and add some guard…
5252c8d 
…s in SimpleTextDisplayer (#7805)

Fixes #7803
@shaka-bot shaka-bot mentioned this pull request Jan 6, 2025
Merged
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
@avelad @joeyparrish
fix: Remove useless deprecation in UITextDisplayer and add some guard…
413196e 
…s in SimpleTextDisplayer (#7805)

Fixes #7803
@shaka-bot shaka-bot mentioned this pull request Jan 6, 2025
Merged
joeyparrish pushed a commit that referenced this pull request Jan 6, 2025
@avelad @joeyparrish
fix: Remove useless deprecation in UITextDisplayer and add some guard…
9364bc6 
…s in SimpleTextDisplayer (#7805)

Fixes #7803
@shaka-bot shaka-bot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

Deprecation Warning and Subtitle Error on Updating to v4.12.5
3 participants
@avelad @shaka-bot @theodab