Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with non-linear IMA CS ads #3639

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Integrate with non-linear IMA CS ads #3639

merged 5 commits into from
Oct 18, 2021

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 16, 2021

Close: #2596

@avelad
Copy link
Member Author

avelad commented Sep 16, 2021

Example:
image

@avelad
Copy link
Member Author

avelad commented Oct 15, 2021

@theodab can you review it?

theodab
theodab approved these changes Oct 18, 2021
View reviewed changes
ui/controls.js Show resolved Hide resolved
theodab
theodab requested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll turn this into "request changes", in that case.

@shaka-bot
Copy link
Collaborator

All tests passed!

@avelad avelad requested a review from theodab October 18, 2021 17:58
@shaka-bot
Copy link
Collaborator

All tests passed!

@theodab theodab merged commit 9c3bed3 into shaka-project:master Oct 18, 2021
@theodab
Copy link
Contributor

theodab commented Oct 18, 2021

Thank you for your contributions as always, Alvaro!

@avelad avelad deleted the cs-non-linear branch October 19, 2021 05:35
@svhemanth
Copy link

ABR is not working when the Non-liner ad is displayed and not even any option in the overflow menu.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate with non-linear IMA CS ads
4 participants
@avelad @shaka-bot @theodab @svhemanth