fix(WebVTT): Add support to , ‎ and ‏ #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
joeyparrish
requested changes
Jan 20, 2023
lib/text/vtt_text_parser.js
Outdated
| @@ -955,10 +955,13 @@ shaka.text.VttTextParser = class { | |||
| '>': '>', | |||
| '"': '"', | |||
| ''': '\'', | |||
| ' ': ' ', | |||
There was a problem hiding this comment.
To preserve the non-breaking space, use '\u{a0}'
lib/text/vtt_text_parser.js
Outdated
| @@ -955,10 +955,13 @@ shaka.text.VttTextParser = class { | |||
| '>': '>', | |||
| '"': '"', | |||
| ''': '\'', | |||
| ' ': ' ', | |||
| '‎': '', | |||
There was a problem hiding this comment.
Left-to-right mark in unicode is '\u{200e}'
lib/text/vtt_text_parser.js
Outdated
| @@ -955,10 +955,13 @@ shaka.text.VttTextParser = class { | |||
| '>': '>', | |||
| '"': '"', | |||
| ''': '\'', | |||
| ' ': ' ', | |||
| '‎': '', | |||
| '‏': '', | |||
There was a problem hiding this comment.
Right-to-left mark in unicode is '\u{200f}'
This could be important for layout of multi-lingual text in some RTL languages.
joeyparrish
approved these changes
Jan 20, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jan 30, 2023
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
Backported to v4.2.x, also includes #4660 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
Backported to v4.2.x, also includes #4660 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
joeyparrish
added a commit
that referenced
this pull request
Jan 30, 2023
Backported to v4.2.x, also includes #4660 Co-authored-by: Joey Parrish <joeyparrish@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.