Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use the first line of ffprobe's output #120

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

mariocynicys
Copy link
Contributor

@mariocynicys mariocynicys commented Mar 9, 2022

With some container formats (such as ts), ffprobe reports the output twice with newline characters in between. This fix is to take into consideration only the first line of ffprobe's output.

Closes #119

With some container formats (such as `ts`), ffprobe reports the output twice with newline characters in between. This fix is, to take into consideration only the first line of ffprobe's output.
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Mar 9, 2022
@joeyparrish joeyparrish merged commit 4d7d077 into shaka-project:main Mar 9, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS input autodetection fails
2 participants